Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix of Notice: Undefined index: Address1 #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bnowak
Copy link

@bnowak bnowak commented Nov 9, 2017

Occurrence of BusinessAddress (and ShippingAddress) in response of command GetOrderList is optional. So according to documentation sometimes response can look like:

[...]
    <Order>
        <ArchiveParcelList>false</ArchiveParcelList>
        <BillingAddress i:nil="true"/>
        <Corporation i:nil="true"/>
        <CreationDate>2017-11-07T21:22:23.98</CreationDate>
[...]
        <OrderState i:nil="true"/>
    </Order>
[...]

In this case i getting notice: Undefined index: Address1
Parsing this response doesn't match the documentation.

@gcmikolaj
Copy link

+1

@gralec99
Copy link

Please approve

@rmalodobry
Copy link

Taking for consideration that documentations explicits says that this field is voluntary, this if checkout of additional is required to get ride off unnecessary notices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants