Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Almost) all unit tests to pytest #159

Merged
merged 19 commits into from
Mar 1, 2022
Merged

Conversation

lbluque
Copy link
Collaborator

@lbluque lbluque commented Mar 1, 2022

Summary

Translated all unit tests in cofe from unittests to pytests.

Some deprecations of unused methods along the way.

TODO (if any)

  • Notably EwaldTerm tests still need to be translated, and actually improved.
  • A few missing (but not critical) tests and improvements listed as #TODOs in corresponding files.

Checklist

@lbluque
Copy link
Collaborator Author

lbluque commented Mar 1, 2022

missing tests as detailed but the bulk work is done so that can be done without feature branch. merging.

@lbluque lbluque merged commit 5519bed into CederGroupHub:master Mar 1, 2022
@lbluque lbluque deleted the pytests branch March 1, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant