Merge pull request #7 from thomasjammet/dev

feat(adapter): get rid of webrtc-adapter

README.md

@@ -44,7 +44,6 @@ import * as WebRTC from '@ceeblue/webrtc-client';
 >      }
 >   }
 >   ```
-> - To avoid potential issues with backward compatibility or problems on iOS when using  `navigator.mediaDevices.getUserMedia`, we recommend including the [WebRTC adapter](https://github.com/webrtcHacks/adapter) in the final project. This often mitigates common compatibility issues on certain older devices.
 
 ### Publish a stream
 

examples/player-with-timed-metadata.html

@@ -21,7 +21,7 @@ <h2>WebRTC Client Timed Metadata Player Example</h2>
         <textarea id="metadata" rows="10" readonly></textarea>
 
         <script type="module">
-            import { Player, Util, NetAddress } from "/dist/webrtc-client.js";
+            import { Player, Util, NetAddress } from "../dist/webrtc-client.js";
 
             const logs = document.getElementById("metadata");
             const videoElement = document.getElementById('video');

examples/player.html

@@ -120,8 +120,6 @@ <h3 class="text-center">WebRTC Client Player Example</h3>
             </div>
         </div>
 
-        <!-- Avoid naming issues with Apple devices : -->
-        <script src="https://cdn.jsdelivr.net/npm/webrtc-adapter/out/adapter.js"></script>
         <script type="module">
             import { Player, HTTPConnector, WSController, Util, NetAddress } from "../dist/webrtc-client.js";
             // development version, includes helpful console warnings

examples/streamer.html

@@ -175,7 +175,6 @@ <h4 class="text-center font-weight-bold">On Air</h4>
         <!--<script src="https://cdn.jsdelivr.net/npm/vue@2/dist/vue.js"></script>-->
         <!-- production version, optimized for size and speed -->
         <script src="https://cdn.jsdelivr.net/npm/vue@2"></script>
-        <script src="https://cdn.jsdelivr.net/npm/webrtc-adapter/out/adapter.js"></script>
         <script type="module">
             import { Streamer, HTTPConnector, WSController, Util, NetAddress } from "../dist/webrtc-client.js";
             console.log('webrtc-client version:', Util.VERSION);

src/connectors/SIPConnector.ts

@@ -11,6 +11,8 @@ import { SDP } from '../utils/SDP';
 import { Util } from '../utils/Util';
 import { ConnectionInfos, IConnector } from './IConnector';
 
+const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
+
 /**
  * SIPConnector is a common abstract class for negotiating a new RTCPeerConnection connection
  * with the server.
@@ -221,7 +223,7 @@ export abstract class SIPConnector extends EventEmitter implements IConnector {
         }
         // Start the RTCPeerConnection and create an offer
         try {
-            this._peerConnection = new RTCPeerConnection(iceServer ? { iceServers: [iceServer] } : undefined);
+            this._peerConnection = new RTCPeerConnection({ iceServers: [iceServer] });
         } catch (e) {
             this.close('RTCPeerConnection failed, ' + Util.stringify(e));
             return;
@@ -239,6 +241,22 @@ export abstract class SIPConnector extends EventEmitter implements IConnector {
             };
         }
 
+        // Add transceivers for Safari
+        // This is necessary for Safari to handle the audio and video tracks correctly
+        if (isSafari) {
+            if (!this._stream) {
+                this._peerConnection.addTransceiver('audio', { direction: 'recvonly' });
+                this._peerConnection.addTransceiver('video', { direction: 'recvonly' });
+            } else {
+                const transceivers = this._peerConnection.getTransceivers();
+                for (const transceiver of transceivers) {
+                    if (transceiver.receiver.track.kind === 'audio' || transceiver.receiver.track.kind === 'video') {
+                        transceiver.direction = 'sendonly';
+                    }
+                }
+            }
+        }
+
         let sdp: string;
         this._peerConnection
             .createOffer({ offerToReceiveAudio: !this._stream, offerToReceiveVideo: !this._stream })