Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sun halo in different starfield rendering modes #541

Closed
375gnu opened this issue Nov 29, 2019 · 4 comments · Fixed by #849
Closed

Sun halo in different starfield rendering modes #541

375gnu opened this issue Nov 29, 2019 · 4 comments · Fixed by #849
Labels
bug Something isn't working renderer

Comments

@375gnu
Copy link
Member

375gnu commented Nov 29, 2019

Both in 1.6 and 1.7 versions. Depending on starfield's style a sun halo either present or not:
No halo with scaled disks:
disks
Halo present with points and fuzzy points:
fuzzy
points

1.7 had the same behaviour before #533. Now it has less bright halo in «points» and «fuzzy points» modes.

Quite interesting is that Alexell's version didn't have this bug. UPD: when vp&fp programs doesn't present, so older strarfied with quads is in use.

@375gnu 375gnu added bug Something isn't working renderer labels Nov 29, 2019
@SevenSpheres
Copy link
Contributor

solution: implement #2

@SevenSpheres
Copy link
Contributor

1.7 had the same behaviour before #533. Now it has less bright halo in «points» and «fuzzy points» modes.

I can confirm this; in fact I've mentioned it in #523 and #589, and made a duplicate issue for it at #596 (sorry!) Still agreed with my comment above. I'll post my screenshots again here.

Sun in older 1.7 build, with star style set to fuzzy points:
nonbuggysun

Sun in newer 1.7 build, with star style set to fuzzy points:
darksunbug2

@SevenSpheres
Copy link
Contributor

This apparently affects Celestia Origin's rogue planet addon as well (BlendTexture seems to be broken):

rogueplanetbug

@375gnu I think this should be labeled "high priority".

@375gnu
Copy link
Member Author

375gnu commented Feb 10, 2020

These visual glitches are related, but are not the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working renderer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants