Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade project to VS 2017, and update for 64-bit support. #12

Merged
merged 7 commits into from
Apr 19, 2017

Conversation

dbrant
Copy link
Contributor

@dbrant dbrant commented Apr 8, 2017

This set of commits allows us to build the project using Visual Studio 2017, as well as updates the code for 64-bit Windows (and adds an x64 build target). Other notes:

  • Upgrade to Eigen version 3.3, and update the code accordingly.
  • Upgrade to libpng 1.6.29.

No functional changes, just adapting to API changes in Eigen.
This updates the code to build for an x64 target.
- Provide prebuilt x64 static libraries.
- Update Windows dialog code for 64-bit support.
- Update libpng to 1.6.29.

Still a few issues:
- Sound (fmod) isn't working correctly in 64-bit.
@dbrant dbrant changed the title Upgrade project to be buildable in VS 2017. Upgrade project to VS 2017, and update for 64-bit support. Apr 9, 2017
@dbrant
Copy link
Contributor Author

dbrant commented Apr 10, 2017

This would take care of #1 as well.

@CelestiaProject
Copy link
Collaborator

CelestiaProject commented Apr 17, 2017

Hey. Thanks for the work you've done. It is really big and important for us. Your Celestia version compiles for Win32 and Win64 correctly? Celestia works without errors? Also interested in QT version, since it will be the basis for Celestia 1.7.0

@Alexell
Copy link
Contributor

Alexell commented Apr 17, 2017

FMOD was taken from here (FMOD Studio for Unreal Engine 4 (4.15) section. I think that I did not use it correctly, because Celestia sometimes crashes with fmod.dll exception. (described in #6)

If you can help to properly use FMOD, that it works correctly on x86 and x64, and also supported on Mac and Linux (Celestia is cross-platform) - I will be very grateful to you.

@dbrant
Copy link
Contributor Author

dbrant commented Apr 19, 2017

To answer your questions:

  • Yes, with these patches, Celestia compiles successfully for Win32 and 64, and runs without errors. The only issue seems to be with FMOD, as you've described.
  • I haven't tried building it with Qt, but I can't imagine that these patches break the existing Qt frontend, since none of my changes really touch the Qt side of things. I'll give it a try later. I'll also verify that it still builds and runs correctly in Linux and Mac.

I did also have a question of my own:

  • How do you generate the installer package (for Windows)? I'm not too familiar with making installers; I've used NSIS a long time ago, but it doesn't seem like that's being used here...

@Alexell
Copy link
Contributor

Alexell commented Apr 19, 2017

Yes, with these patches, Celestia compiles successfully for Win32 and 64, and runs without errors. The only issue seems to be with FMOD, as you've described.

If you can properly connect FMOD, so that it works on win32, win64, qt, mac and linux - we will be very grateful, like many users who will then use the program.

... none of my changes really touch the Qt side of things ...

If we update the project, I would like to ask you to update the QT version. Now I use QT4 (I compile with QT 4.8.0 and QT Creator 2.5.2). I would like to use the new QT and QT Creator, respectively.

How do you generate the installer package (for Windows)?

Previously Celestia installer was collected through Inno Setup (file celestia.iss). Now before the release we are still far away, so I did not think what program we will use for this.

@CelestiaProject CelestiaProject merged commit 3451f57 into CelestiaProject:master Apr 19, 2017
@CelestiaProject CelestiaProject added the enhancement New feature or request label Apr 19, 2017
SevenSpheres pushed a commit to SevenSpheres/Celestia that referenced this pull request Apr 10, 2020
SevenSpheres pushed a commit to SevenSpheres/Celestia that referenced this pull request May 13, 2020
[ci] Don't install fmt to workaround bugs in 6.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants