Update celestia.cfg and README #660
Conversation
|
Linking CelestiaContent#19 |
| M "mstar.*" | ||
| O "star-type-o.*" | ||
| B "star-type-b.*" | ||
| A "star-type-a.*" |
There was a problem hiding this comment.
Why are the star textures renamed? Wouldn't it make more sense to keep the names from earlier, for the sake of compatibility?
There was a problem hiding this comment.
I don't know, those are FarGetaNik's names for them. The last release of Celestia Origin renamed their star textures in the same way. I don't think any of the old star textures are referenced in data files or addons, so there wouldn't be compatibility problems (note that I did keep the old browndwarf texture, for the sake of compatibility).
There was a problem hiding this comment.
Give me a good reason why.
There was a problem hiding this comment.
Compatibility - I'm pretty sure there are older add-ons on the Motherlode that use "mstar.", "gstar.", etc.
There was a problem hiding this comment.
Like, way back when binary stars had to be defined as planets?
I prefer all the textures beginning with "star", but if everyone disagrees I'll rename them.
There was a problem hiding this comment.
Maybe, but I'm also talking about add-ons like these where they use the original naming format.
There was a problem hiding this comment.
sigh...I really don't feel like doing this right now.
Why isn't it there already? In CelestiaContent#4 you wrote:
|
i'm not perfect and do mistakes. |
For new star textures in CelestiaContent
SevenSpheres
force-pushed
the
star-textures
branch
from
c52f4f8
to
b9b9f5a
Compare
For new star textures in CelestiaContent. Previously #477. Closes #113, once the corresponding PR in CelestiaContent is merged as well. The main repository still has the old data files, making things very confusing...