Various #112
Merged
Various #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totally re-wrote the AT Command Injection system using the RootTools library which has helped simplify the system, this change should hopefully bring back the same (if not better) level of functionality experienced with earlier alpha releases. Unable to test AT Commands on either of my devices but shell commands return expected results, so hopefully once tested AT Command execution can be confirmed. RootTools v3.5 - https://github.com/Stericson/RootTools Added to project under libs directory, gradle build config updated but you may need to check your IDE to confirm it is including RootTools.jar if you face any problems.
Reverted notification behaviour so the idle (grey) icon is shown whilst the app is running but not actively engaged in any task, normal (green) will display when tracking or monitoring cell details and warning and alarm icons will be displayed when triggered by changed LAC, femtocell detection etc.
Corrected the Cell Monitoring method so it will now correctly update the notification icon based on the Cell Monitoring status.
The prompting to enable GPS now better handles the users selection and detects if GPS was actually activated when taken to the settings fragment. The activity itself forces a check as I cannot use the method startActivityForResult from within the service, so whenever the activity binds to the service or invokes onResume it will check the GPS location service is running if Cell Tracking is enabled. This also forces the user to either enable GPS or cancel the dialog box which will leave the app in a desired state of operation.
This was referenced Sep 15, 2014
|
Thank you very much for this awesome pull request, @xLaMbChOpSx! |
SecUpwN
pushed a commit
that referenced
this pull request
Sep 15, 2014
Various bugfixes, improvements and updates
SecUpwN
pushed a commit
that referenced
this pull request
Jan 2, 2015
Various bugfixes, improvements and updates
SecUpwN
pushed a commit
that referenced
this pull request
Apr 17, 2015
Various bugfixes, improvements and updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiled app for testing can be found here
Commits contain full details for changes below: