Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possessive adjective in hooks2 "time traveller obsessed with finding his/her descendant" #6

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

Cellule
Copy link
Owner

@Cellule Cellule commented Oct 23, 2022

Simplify gender attribution and reduce duplication Removed "medusa" table and inline it in race instead, change stats attribution to medusa to compensate for default female stats modifications.

Closes #2
I looked as hard as I could and couldn't find other "gender" inconsistencies other than that one


This change is Reviewable

@Cellule Cellule force-pushed the gender branch 2 times, most recently from 280f04e to c78464a Compare October 23, 2022 21:03
Copy link
Owner Author

@Cellule Cellule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, all discussions resolved


src/tables/medusa.json line 1 at r1 (raw file):

[{ "w": 1, "v": "{$gender=female}{$majPoss=Her }{$minPoss=her }{$majPro=She }{$minPro=she }{$workGender=woman}{$minHim=her}{$beard=}{medusahair}" }]

urgg I just noticed that female also reduces height by 10...

"v": "{$gender=female}{%str-1}{%dex+1}{%con-1}{%wis+1}{%cha+1}{$majPoss=Her }{$minPoss=her }{$majPro=She }{$minPro=she }{%height-10}{$workGender=woman}{$minHim=her}{$beard=}"

I might split base female (like gender pronouns and such) from the stats changes

Copy link
Owner Author

@Cellule Cellule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, all discussions resolved


src/tables/medusa.json line 1 at r1 (raw file):

Previously, Cellule (Michael "Mike" Ferris) wrote…

urgg I just noticed that female also reduces height by 10...

"v": "{$gender=female}{%str-1}{%dex+1}{%con-1}{%wis+1}{%cha+1}{$majPoss=Her }{$minPoss=her }{$majPro=She }{$minPro=she }{%height-10}{$workGender=woman}{$minHim=her}{$beard=}"

I might split base female (like gender pronouns and such) from the stats changes

@etiens what do you think? Are Medusas same height as men or should they be shorter
Basically, should I revert it, so I don't change this stat or is it fine to make them shorter?

@etiens
Copy link
Collaborator

etiens commented Oct 23, 2022

It's fine if Medusa are shorter, after all they were human or elf females that got cursed to become medusas, so it makes sense that they'd have the same height.

…ing his/her descendant"

Simplify gender attribution and reduce duplication
Removed "medusa" table and inline it in race instead, change stats attribution to medusa to compensate for default female stats modifications
@Cellule Cellule requested a review from etiens October 26, 2022 11:56
@Cellule Cellule self-assigned this Oct 26, 2022
@Cellule Cellule added the bug Something isn't working label Oct 26, 2022
@Cellule Cellule merged commit 9371b89 into master Nov 13, 2022
@Cellule Cellule deleted the gender branch November 13, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor inconsistencies with pronouns with sex selection
2 participants