Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Edit Last.fm Scrobbles] trouble with ampersands in edit fields #12

Closed
nicoleahmed opened this issue May 7, 2024 · 4 comments
Closed

[Edit Last.fm Scrobbles] trouble with ampersands in edit fields #12

nicoleahmed opened this issue May 7, 2024 · 4 comments

Comments

@nicoleahmed
Copy link
Contributor

Hi
A small issue

Ampersands in fields -e.g. name "Ray Of Sun - Sub Focus & Wilkinson" will not allow edits to be saved

Thanks
Nicole
@nicoleahmed
Copy link
Contributor Author

I've had a look at this - but I am a novice

realised the issue was around uri encoding where there are ampersands involved

see here: https://stackoverflow.com/questions/5503869/last-fm-api-and-the-character

@nicoleahmed nicoleahmed mentioned this issue May 8, 2024
Merged
@nicoleahmed
Copy link
Contributor Author

nicoleahmed commented May 8, 2024 •
edited
Loading

I had a go at fixing this - seems to be working for me - please feel free to optimise

changes:
encode artist and track fields
change handling of md5 to overcome ampersands issue
reload table to show plain text instead of uri encoded text

nicoleahmed added a commit to nicoleahmed/CennoxXuserscripts that referenced this issue May 9, 2024
@nicoleahmed
Update Last.fm Edit Scrobbles.user.js
e603b4e 
Possible fix for CennoxX#12
encode artist and track fields
change handling of md5 to overcome ampersands issue
reload table to show plain text instead of uri encoded text
nicoleahmed added a commit to nicoleahmed/CennoxXuserscripts that referenced this issue May 9, 2024
@nicoleahmed
Update Last.fm Edit Scrobbles.user.js
9add98c 
tidied up
Possible fix for CennoxX#12
encode artist and track fields
change handling of md5 to overcome ampersands issue
reload table to show plain text instead of uri encoded text
@CennoxX
Copy link
Owner

CennoxX commented May 9, 2024

Thank you very much for fixing this bug.

@CennoxX CennoxX closed this as completed May 9, 2024
@nicoleahmed
Copy link
Contributor Author

You're welcome - thank you for sharing the script in the first place

@CennoxX CennoxX mentioned this issue May 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CennoxX @nicoleahmed