Add guards for unusable CLI arg combinations #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gouvernathor
reviewed
Apr 2, 2024
Gouvernathor
reviewed
Apr 2, 2024
|
Looks good. |
madeddy
added a commit
to madeddy/unrpyc
that referenced
this pull request
Apr 4, 2024
* Add guards for unusable CLI arg combinations
madeddy
added a commit
to madeddy/unrpyc
that referenced
this pull request
Apr 4, 2024
* Add guards for unusable CLI arg combinations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ #211
I didn't add any other guards for translation args, because this feat, as discussed, is at given time about to change. In addition, this three args manage to produce alone five bad combinations between themselves i am aware of.
Args init-offset and sl-displayable i could not check as i have no testcases for them, but from the code i see so far no possible problems.