Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protobuf downgrade #17

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Fix protobuf downgrade #17

merged 2 commits into from
Nov 4, 2022

Conversation

anurlybayev
Copy link
Contributor

@anurlybayev anurlybayev commented Nov 3, 2022

The change introduced in #15 broke the installation process. This PR fixes it. Without these changes on the main branch I would get the following error:

$ poetry install
Installing dependencies from lock file

Package operations: 0 installs, 4 updates, 0 removals

  • Updating typing-extensions (4.4.0 -> 4.3.0)
  • Updating numpy (1.23.4 -> 1.23.3)
  • Updating protobuf (4.21.9 -> 3.18.3): Failed

  RuntimeError

  Retrieved digest for link protobuf-3.18.3.tar.gz(sha256:196a153e487c0e20d62259872bbf2e1c4fa18e2ce97e20984fcbf9d8b151058d) not in poetry.lock metadata ['sha256:49f88d56a9180dbb7f6199c920f5bb5c1dd0172f672983bb281298d57c2ac8eb', 'sha256:7a6cc8842257265bdfd6b74d088b829e44bcac3cca234c5fdd6052730017b9ea', 'sha256:ba596b9ffb85c909fcfe1b1a23136224ed678af3faf9912d3fa483d5f9813c4e', 'sha256:4143513c766db85b9d7c18dbf8339673c8a290131b2a0fe73855ab20770f72b0', 'sha256:b6cea204865595a92a7b240e4b65bcaaca3ad5d2ce25d9db3756eba06041138e', 'sha256:9666da97129138585b26afcb63ad4887f602e169cafe754a8258541c553b8b5d', 'sha256:308173d3e5a3528787bb8c93abea81d5a950bdce62840d9760effc84127fb39c', 'sha256:aa29113ec901281f29d9d27b01193407a98aa9658b8a777b0325e6d97149f5ce', 'sha256:8f9e60f7d44592c66e7b332b6a7b4b6e8d8b889393c79dbc3a91f815118f8eac', 'sha256:80e6540381080715fddac12690ee42d087d0d17395f8d0078dfd6f1181e7be4c', 'sha256:77b355c8604fe285536155286b28b0c4cbc57cf81b08d8357bf34829ea982860', 'sha256:07a0bb9cc6114f1https://mail.google.com/mail/u/0/6a39c866dc28b6e3d96fa4ffb9cc1033057412547e6e75cb9', 'sha256:c7c864148a237f058c739ae7a05a2b403c0dfa4ce7d1f3e5213f352ad52d57c6', 'sha256:6b1040a5661cd5f6e610cbca9cfaa2a17d60e2bb545309bc1b278bb05be44bdd']

  at ~/.local/share/pypoetry/venv/lib/python3.8/site-packages/poetry/installation/chooser.py:144 in _get_links
      140│
      141│             selected_links.append(link)
      142│
      143│         if links and not selected_links:
    → 144│             raise RuntimeError(
      145│                 f"Retrieved digest for link {link.filename}({h}) not in poetry.lock"
      146│                 f" metadata {hashes}"
      147│             )
      148│

  • Updating torch (1.13.0 -> 1.12.1)

The correct way to downgrade dependencies is to make the change in pyproject.toml and let poetry update the lock file by running:

$ poetry lock --no-update

That's what I did in this PR.

@anurlybayev anurlybayev marked this pull request as ready for review November 3, 2022 02:56
@michaelshin
Copy link
Contributor

I did not realize Poetry locked dependencies this way. Thanks Akbar for the heads-up.

Copy link
Contributor

@michaelshin michaelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@anurlybayev anurlybayev merged commit 0b68cfb into main Nov 4, 2022
@anurlybayev anurlybayev deleted the fix-protobuf branch November 4, 2022 15:11
@michaelshin michaelshin mentioned this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants