Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multiple frontend instances and a single Skyline server #29

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

michaelshin
Copy link
Contributor

  • Refactored Skyline so an entry point is not required to launch Skyline.
  • Added the entry point and project root as part of the initialization request message and saved the entry point/project root for each connection

@jimgao1
Copy link
Contributor

jimgao1 commented Jan 16, 2023

Generally looks good to me!

However, we might want to have some mutual exclusion mechanism to ensure that only one profiling session can be executing at any given time. This is to ensure that we don't get interference from runtime (i.e. two models running together slowly) or memory (i.e. if it OOMs).

@michaelshin
Copy link
Contributor Author

The ThreadPoolExecutor that actually runs the profile only has one worker so I believe we do not need to add an additional mutual exclusion mechanism. Do you think this is sufficient?

Copy link
Contributor

@jimgao1 jimgao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@michaelshin michaelshin marked this pull request as ready for review January 19, 2023 20:24
@michaelshin michaelshin merged commit 34bc2db into main Jan 20, 2023
@michaelshin michaelshin deleted the add-support-for-multiple-frontend-connections branch January 20, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants