Added energy consumption to Skyline #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michaelshin
commented
Jan 24, 2023
michaelshin
commented
- Added energy measurement to Skyline
- Created new protobuf messages to send to the frontend
- Handled sending new message type
michaelshin
requested review from
anurlybayev,
jimgao1,
ssaini4 and
johncalesp
ssaini4
reviewed
Jan 24, 2023
skyline/analysis/request_manager.py
Outdated
| @@ -107,6 +107,23 @@ def _handle_analysis_request(self, analysis_request, context): | |||
| context, | |||
| ) | |||
|
|
|||
| # send energy response | |||
| if not context.state.connected: | |||
| logger.debug( | |||
There was a problem hiding this comment.
Yes makes sense. I'll update the other conditions as well
| resp = pm.EnergyResponse() | ||
| try: | ||
| energy_measurer.begin_measurement() | ||
| iterations = 20 |
There was a problem hiding this comment.
maybe we can declare this variable outside the try block
There was a problem hiding this comment.
What's the reason that it should be outside the try block? I'm not sure I understand why
There was a problem hiding this comment.
I think it will be easier to read if all the variables are declared at the beginning of the function. At least the ones that can be
jimgao1
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.