Fix passing parameters to OpenShift templates #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The playbook contains a lot of code that deals with and prepares parameters for passing into OpenShift templates with instantiating them. Only it seems that the values that were prepared were not being used for some reason. This patch attempts to fix that. Signed-off-by: Barak Korren <bkorren@redhat.com>
|
Can one of the admins verify this patch? |
arilivigni
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The playbook contains a lot of code that deals with and prepares parameters for passing into OpenShift templates with instantiating them.
Only it seems that the values that were prepared were not being used for some reason. This patch attempts to fix that.
Signed-off-by: Barak Korren bkorren@redhat.com