Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for linchpin validate #688

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Add unit tests for linchpin validate #688

merged 1 commit into from
Sep 19, 2018

Conversation

14rcole
Copy link
Collaborator

@14rcole 14rcole commented Sep 12, 2018

No description provided.

@adl-bot
Copy link

adl-bot commented Sep 12, 2018

Can one of the admins verify this patch?

@adl-bot
Copy link

adl-bot commented Sep 12, 2018

ci-linchpin-messageBus-trigger build #297: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/297/

@adl-bot
Copy link

adl-bot commented Sep 12, 2018

ci-linchpin-messageBus-trigger build #298: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/298/

@adl-bot
Copy link

adl-bot commented Sep 12, 2018

ci-linchpin-messageBus-trigger build #300: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/300/

@14rcole
Copy link
Collaborator Author

14rcole commented Sep 13, 2018

[test]

@adl-bot
Copy link

adl-bot commented Sep 13, 2018

ci-linchpin-messageBus-trigger build #302: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/302/

@adl-bot
Copy link

adl-bot commented Sep 13, 2018

ci-linchpin-messageBus-trigger build #305: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/305/

@herlo herlo added this to the v1.6.3 milestone Sep 17, 2018
herlo
herlo approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@herlo herlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single nit below. Otherwise, LGTM

linchpin/tests/utils/test_validator_pass.py Outdated Show resolved Hide resolved
@14rcole
Add unit tests for linchpin validate
3cf4d1b 
Signed-off-by: Ryan Cole <rycole@redhat.com>
@adl-bot
Copy link

adl-bot commented Sep 18, 2018

ci-linchpin-messageBus-trigger build #333: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/333/

@14rcole
Copy link
Collaborator Author

14rcole commented Sep 19, 2018

[merge]

@adl-bot adl-bot merged commit 52cbebf into CentOS-PaaS-SIG:develop Sep 19, 2018
@14rcole 14rcole deleted the validate-unit-tests branch September 19, 2018 13:33
@adl-bot adl-bot mentioned this pull request Dec 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herlo herlo herlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@14rcole @adl-bot @herlo