-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linchpincli and setup.py #88
Linchpincli and setup.py #88
Conversation
Installing this in a virtualenv gives the following errors:
|
@herlo : could you try cd into the folder and try python setup.py install. |
@herlo : followup commits should resolve the issues in virtualenv . |
This would be a problem in a virtualenv. One cannot assume /etc/linchpin to exist with the python package. Instead, I might suggest the path be altered based upon the virtualenv path. |
@herlo 👍 |
requirements.txt still has shade==1.9.0 listed twice. Additionally, most reqs should not be pinned (==), but rather set to a minimum version (>=). Can you adjust this? |
@@ -55,6 +55,6 @@ def list_all_files(root_dir): | |||
'templates': list_all_files('templates'), | |||
}, | |||
data_files=[ | |||
('/etc/linchpin', ['linchpin_config.yml']), | |||
('linchpin_config.yml', ['linchpin_config.yml']), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this is the way you should do this. Instead, I'd suggest the following
('', ['linchpin_config.yml'])
Additionally, the version should currently be 0.8.1, maybe? Definitely not 1.0. :)
apache-libcloud>=0.20.1 | ||
sphinx>=1.4.4 | ||
jsonschema>=2.5.1 | ||
ansible>=2.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pin this to ansible==2.1.2 per the irc conversation wtih @arilivigni
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to add functools32 to the requirements.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And what about jinja2??
Moving the discussion from email now that my internet is working. Here's the replay
Further thought here leads me down this path. Let's call the file 'Pinfile'. It allows us to detail which services being pinned, or using. One can have multiple configurations in a single file, or multiple files, each with a single configuration in a directory. The configurations could be defined simply to point to a topology file. Each section would have a named cluster or configuration, such as 'across2clouds', providing semantics for the human reader. Additionally, an inventory layout, playbooks which could use the resulting inventory, and more could be provided, allowing configuration of the provisioned resources in some way. There may be other bits that would live in this file down the road. Time will tell. It seems linchpin init is going in the right path, especially if we document the Pinfile with good examples and such. |
linchpin init should add an additional line at the bottom of the file for completeness. It appears linchpin list currently does nothing?
How does one configure linchpin get to pull from a repository of linchpin topologies or layouts? I like the idea here, but maybe we should create a simple github repository with topologies and layouts from which to pull? Kind of like the atomic/docker registry. |
@herlo : linchpin list shpuld be called with --topos or --layouts , |
removed multiple declarations of linchpin list
@herlo In order to get list from a remote we might have to have additional option --remote to fetch the list of layouts and topologies from, and it changes the how we fetch using linchpin get . I will add enhancement to the current functionality which will be addressed soon after the linchpin cli is merged successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding those two bugs has satisfied this PR. Approved.
Summary:
Added setup.py for linchpin cli packaging
contains templates
contains basic implementation