make sure scratch build from PR finished #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgoncalv
force-pushed
the
fedoraci-runner
branch
from
a55e0f4
to
f0aea42
Compare
bgoncalv
changed the title
bgoncalv
force-pushed
the
fedoraci-runner
branch
from
f0aea42
to
f620ed2
Compare
|
@thrix could you check this? |
hroncok
reviewed
Oct 15, 2019
| popd | ||
|
|
||
| SCRATCHID=$(cat ${LOGDIR}/kojioutput.txt | awk '/Created task:/ { print $3 }') | ||
| echo "koji_task_id=${SCRATCHID}" >> ${LOGDIR}/job.props | ||
|
|
||
| # Make sure koji build finished | ||
| # https://pagure.io/fedora-ci/general/issue/76 | ||
| while koji taskinfo ${SCRATCHID} | grep "State: open"; do |
There was a problem hiding this comment.
this (taskinfo) could have a temporary error that leads to grep failure. also, the status could be "free". should this grep the other way around (i.e. continue to loop if it cannot grep closed|failed|cancelled?
bgoncalv
force-pushed
the
fedoraci-runner
branch
from
f620ed2
to
709acd9
Compare
hroncok
reviewed
Oct 15, 2019
| popd | ||
|
|
||
| SCRATCHID=$(cat ${LOGDIR}/kojioutput.txt | awk '/Created task:/ { print $3 }') | ||
| echo "koji_task_id=${SCRATCHID}" >> ${LOGDIR}/job.props | ||
|
|
||
| # Make sure koji build finished | ||
| # https://pagure.io/fedora-ci/general/issue/76 | ||
| while koji taskinfo ${SCRATCHID} | grep "State:" | grep -Ev "closed|failed|cancelled"; do |
| fi | ||
| done | ||
|
|
||
| echo "status=SUCCESS" >> ${LOGDIR}/job.props |
There was a problem hiding this comment.
...it jumps here and sets the result to success.
bgoncalv
force-pushed
the
fedoraci-runner
branch
from
709acd9
to
d1bd49e
Compare
hroncok
approved these changes
Oct 15, 2019
|
@bgoncalv seems legit to me also. so +1 |
|
[merge] |
|
@hroncok thanks for the review :) |
|
The following image promotions have taken place:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://pagure.io/fedora-ci/general/issue/76