Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates postgres README to reflect variable names #128

Merged
merged 1 commit into from Apr 26, 2019
Merged

Updates postgres README to reflect variable names #128

merged 1 commit into from Apr 26, 2019

Conversation

xamebax
Copy link

@xamebax xamebax commented Mar 31, 2017

Updates postgres Dockerfile README to reflect variable names; fixes typo.

@atodorov
Copy link
Contributor

@jperrin, @mohammedzee1000 ping. Any update on this PR? It looks good and it has been 2+ years since it was opened. Anything stopping the merge?

It also includes change from #77 which is almost 3 years old. Please merge if there isn't anything wrong with this PR. Otherwise folks like us will have to fork and maintain our own forks which kind of defeats the collaborative aspect of open source, doesn't it?

@atodorov
Copy link
Contributor

Obsoletes #77 and #132.

@atodorov
Copy link
Contributor

Note:
these variables are published in https://hub.docker.com/r/centos/postgresql-10-centos7 (and have probably been there for a long time), however the source code in this repository doesn't seem to match.

@arrfab arrfab merged commit 13e6933 into CentOS:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants