Add spacing around mptsci module in dracut config

[mvermaes]

When adding the VMware Tools software to the CentOS 7 vagrant box (required to get synced folders working), the following errors are generated during the vmware-config-tools.pl step:

...
Creating a new initrd boot image for the kernel.
/bin/dracut --force --add-drivers "vmxnet3 vmw_pvscsi" 
/boot/initramfs-3.10.0-327.28.3.el7.x86_64.img 3.10.0-327.28.3.el7.x86_64 
>/dev/null 2>&1

Broadcast message from systemd-journald@localhost.localdomain (Tue 2016-09-13 16:57:37 UTC):

dracut[24942]: Failed to install module mptspivmxnet3


Message from syslogd@localhost at Sep 13 16:57:37 ...
 dracut:Failed to install module mptspivmxnet3
...

Adding whitespace around the mptspi module in /etc/dracut.conf.d/vmware-fusion-drivers.conf seems to resolve the issue (on CentOS 7 at least, I haven't tested on CentOS 6).

[centos-ci]

Can one of the admins verify this patch?

[lpancescu]

I see that dracut.sh uses a bash array, add_drivers_l, which it converts to the add_drivers string, taking care to add the necessary spaces. However, the configuration files are executed as bash scripts; since we are appending to the add_drivers variable (a string), we must always have spaces before and after the module names.

@mvermaes I wasn't able to reproduce the error at the beginning: calling /bin/dracut --force --add-drivers "vmxnet3 vmw_pvscsi" in a new "centos/7" box does not show the error, since the command-line argument is added directly to the array. VMware Tools probably also add a configuration file under /etc/dracut.conf.d, which I assume it's also missing the extra spaces, otherwise we wouldn't see this error. Feel free to report this to VMware, if that's true, and thanks for the patch!

LGTM

[mvermaes]

Yes, you're right:

[root@localhost dracut.conf.d]# cat vmware-tools.conf 
add_drivers+="vmxnet3 vmw_pvscsi"

I'll open a support ticket with them about it.

Thanks.

[lpancescu]

This should fix issue #73.