Change SlackAuthor and createElement. Adding .editorconfig

andreyvital · Nov 13, 2017 · e44e4de · e44e4de
1 parent 6b2d6a0
commit e44e4de
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 8 deletions.
diff --git a/.editorconfig b/.editorconfig
@@ -0,0 +1,15 @@
+root = true
+
+[*]
+charset = utf-8
+indent_style = space
+indent_size = 2
+trim_trailing_whitespace = false
+
+[*.md]
+indent_style = tab
+trim_trailing_whitespace = false
+
+[{package.json}]
+indent_style = space
+indent_size = 2
diff --git a/components/SlackAuthor.js b/components/SlackAuthor.js
@@ -14,7 +14,7 @@ class SlackAuthor extends SlackComponent {
     this.props = props;
   }
 
-  addParentAttachment(keyName, value) {
+  setParentAttachment(keyName, value) {
     this.parent.attachment = this.parent.attachment.set(keyName, value);
   }
 
@@ -27,17 +27,17 @@ class SlackAuthor extends SlackComponent {
     const { name, link, icon, children } = this.props;
 
     if (name) {
-      this.addParentAttachment("author_name", name);
+      this.setParentAttachment("author_name", name);
     } else if (children) {
-      this.addParentAttachment("author_name", children);
+      this.setParentAttachment("author_name", children);
     }
 
     if (link) {
-      this.addParentAttachment("author_link", link);
+      this.setParentAttachment("author_link", link);
     }
 
     if (icon) {
-      this.addParentAttachment("author_icon", icon);
+      this.setParentAttachment("author_icon", icon);
     }
   }
 }

diff --git a/utils/createElement.js b/utils/createElement.js
@@ -13,12 +13,11 @@ const SlackAuthor = require("../components/SlackAuthor");
 let rootNodeInstance = null;
 
 exports.getHostContextNode = function getHostContextNode(rootNode) {
-  rootNodeInstance = new SlackRoot();
-
   if (typeof rootNode !== undefined) {
     rootNodeInstance = rootNode;
+  } else {
+    rootNodeInstance = new SlackRoot();
   }
-
   return rootNodeInstance;
 };