Skip to content

Commit

Permalink
Fix indentation and incorrect example
Browse files Browse the repository at this point in the history
  • Loading branch information
sloria committed Mar 30, 2015
1 parent d68ccd6 commit 4907358
Showing 1 changed file with 22 additions and 17 deletions.
39 changes: 22 additions & 17 deletions docs/style_guides/javascript.rst
Original file line number Diff line number Diff line change
Expand Up @@ -121,22 +121,22 @@ Promises

.. code-block:: javascript
// Yes
function makeRequest() {
var request = $.getJSON('/api/projects/');
return request;
}
var request = makeRequest();
request.done(function(response) { console.log(response); })

// No
function noop() {}
function makeRequest(callback){
$.getJSON('/api/projects/', function(response) {
callback(response) || noop;
}) ;
}
makeRequest(function(response) {console.log(response)});
// Yes
function makeRequest() {
var request = $.getJSON('/api/projects/');
return request;
}
var request = makeRequest();
request.done(function(response) { console.log(response); })
// No
function noop() {}
function makeRequest(callback){
$.getJSON('/api/projects/', function(response) {
callback(response) || noop;
}) ;
}
makeRequest(function(response) {console.log(response)});
- When doing AJAX requests or other async work, it's often useful to return a promise that resolves to a useful value (e.g. model objects or "unwrapped" responses).
Expand Down Expand Up @@ -166,7 +166,12 @@ makeRequest(function(response) {console.log(response)});
return ret.promise();
};
getUsers().done(function(user){ console.log(user.username); })
getUsers().done(function(users){
users.forEach(function(user)){
console.log(user._id);
console.log(user.username);
};
})
Encapsulation
Expand Down

0 comments on commit 4907358

Please sign in to comment.