Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EMB-414][Chronos][Preprints]store approved journal ids in config #637

Conversation

adlius
Copy link
Collaborator

@adlius adlius commented Nov 14, 2018

Purpose

Store approved journal ids in config and make use of them in the filter.

Ticket

https://openscience.atlassian.net/browse/Emb-414

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

@adlius adlius changed the title [Emb-414][Chronos][Preprints]store approved journal ids in config [EMB-414][Chronos][Preprints]store approved journal ids in config Nov 14, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 27.994% when pulling 53e4a42 on adlius:IN-372_Add_chronos_submission into a3f2b26 on CenterForOpenScience:feature/chronos.

Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better. 👍

@jamescdavis jamescdavis merged commit 44d1a09 into CenterForOpenScience:feature/chronos Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants