Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-4585] Remove Chronos #759

Conversation

adlius
Copy link
Collaborator

@adlius adlius commented Sep 15, 2023

Purpose

Summary of Changes/Side Effects

Testing Notes

Ticket

https://openscience.atlassian.net/browse/IN-

Notes for Reviewer

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

Copy link
Contributor

@futa-ikeda futa-ikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some Chronos translations and some Chronos styles that can be removed, but not really urgent

@adlius
Copy link
Collaborator Author

adlius commented Sep 15, 2023

Chronos-related styles and translation strings are removed as well.

@futa-ikeda futa-ikeda merged commit 3022db3 into CenterForOpenScience:feature/provider-defaults Sep 15, 2023
2 checks passed
adlius added a commit that referenced this pull request Sep 15, 2023
* [ENG-4460] Toggle assertions based on preprint-provider flag (#756)

* Toggle assertions based on preprint-provider flag

* Update test

* Point package.json to eosf feature branch temporarily

* Add tests for assertionsEnabled

* Update yarn.lock (#757)

* [ENG-4585] Remove Chronos (#759)

* remove chronos

* remove styles and translations

---------

Co-authored-by: Yuhuai Liu <yuhuai@cos.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants