[IN-57][Reviews] Do not show warning on decision submit

[fabmiz]

Purpose

This is a follow-up PR for #108

Fix issue where the user gets a warning modal even after they submit
the decision form.

Summary of Changes

• Set userHasEnteredReview to false on submitDecision action, hence preventing
  the showWarning to be set to true in willTransition action.
• Updated tests

Side Effects / Testing Notes

On the preprint detail page:

• Change the reviewer's decision
• Without submitting the form, attempt to click on any link on the page; make sure you are prevented from navigating forward and shown the warning modal. On the modal, hit stay or leave and see if they behave as expected.
• Back to the preprint detail page, modify decision, and submit. You should not get the warning modal.

Ticket

https://openscience.atlassian.net/browse/IN-57

Reviewer Checklist

• meets requirements
• easy to understand
• DRY
• testable and includes test(s)
• changes described in CHANGELOG.md

[coveralls]

Coverage decreased (-1.4%) to 49.825% when pulling d073763 on fabmiz:feature/IN-57_fix_warning into 4275cb0 on CenterForOpenScience:develop.

[sheriefvt]

looks good to me

[baylee-d]

ember-onbeforeunload has a function that you can call in the router called shouldCheckIsPageDirty, where you can exclude certain routes from the isPageDirty check. In normal preprints, we have the submit route/button exempt from the warning modal on click.

Would it be a better practice to use shouldCheckIsPageDirty here too instead of changing userHasEnteredReview in the controller?

[alexschiller]

@fabmiz See Baylee's comment. Worth exploring as an option, kicking back to AD while you investigate.

[baylee-d]

LGTM. Nice way to use the shouldCheckIsPageDirty function!

[alexschiller]

LGTM 🥇