-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IN-63][Reviews] Use ember-osf queryHasMany #120
[IN-63][Reviews] Use ember-osf queryHasMany #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swap to next interfaces for ember-osf otherwise looks fine
package.json
Outdated
@@ -17,7 +17,7 @@ | |||
"test:cover": "COVERAGE=true yarn test" | |||
}, | |||
"devDependencies": { | |||
"@centerforopenscience/ember-osf": "https://github.com/CenterForOpenScience/ember-osf#feature/reviews#2017-12-21", | |||
"@centerforopenscience/ember-osf": "https://github.com/CenterForOpenScience/ember-osf#df7716240c43af4ef42a191985436279e6e510ec", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run:
yarn use-ember-osf-next-interfaces
to set this to next interfaces instead of a pinned commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. it does not seem like use-ember-osf-next-interfaces
script is defined here yet both develop and release/next-interfaces. I will get it from https://github.com/CenterForOpenScience/ember-osf-preprints/blob/develop/package.json#L19.
…rOpenScience/ember-osf-reviews into feature/IN-63_use_eosf_queryHasMany
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGELOG please
…rOpenScience/ember-osf-reviews into feature/IN-63_use_eosf_queryHasMany
Purpose
Use ember-osf version of
queryHasMany
Summary of Changes
queryHasMany
tomodel.queryHasMany
instead ofqueryHasMany
from reviewsstore
.Side Effects / Testing Notes
These changes affect the preprint detail page and the moderation list page.
On the preprint detail page:
with no errors (please check the console as well.)
On the moderation list page:
Ticket
IN-63
Reviewer Checklist
CHANGELOG.md