[NPD][IN-477][Reviews]Make sure Reviews work with post-NPD changes #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlius
changed the title
pattisdr
suggested changes
Oct 22, 2018
| import { ArrayPromiseProxy, loadRelation } from 'ember-osf/utils/load-relationship'; | ||
|
|
||
| const PAGE_SIZE = 6; | ||
|
|
||
|
|
||
| export default Component.extend({ | ||
| pageNumber: 0, | ||
| selectedFile: null, |
| import { ArrayPromiseProxy, loadRelation } from 'ember-osf/utils/load-relationship'; | ||
|
|
||
| const PAGE_SIZE = 6; | ||
|
|
||
|
|
||
| export default Component.extend({ | ||
| pageNumber: 0, |
pattisdr
approved these changes
Oct 26, 2018
|
@adlius, @jamescdavis, checking in on this one. Can we get these reviews changes on staging3? I assume this needs to go out with NPD. |
|
@brianjgeiger, can this go on staging3? |
|
thank you @jamescdavis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To maintain functional parity with
ember-osf-preprintsonce NPD changes are in effect.Summary of Changes/Side Effects
Deleted some tests that are no longer valid. Change the detail page so that it shows the same header as the post-NPD preprint detail page.
Ticket
https://openscience.atlassian.net/browse/IN-477
Reviewer Checklist
CHANGELOG.md