Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eng-4051] Restylized the osf-dialog to work on small mobile screen when the body needs to scroll #1667

Closed

Conversation

bp-cos
Copy link
Contributor

@bp-cos bp-cos commented Oct 4, 2022

Purpose

To have the osf-dialog work on small mobile screens

Summary of Changes

Converted the lib > analytics-page > addon > application > template.hbs file to use osf-dialog

Updated the osf-dialog scss style to be more reactive.

Screenshot(s)

Before

iPhone IOS and Safari

After
Screen Shot 2022-10-04 at 10 36 59 AM

Side Effects

A million that I have no idea about

QA Notes

Browserstack for a bunch of different configurations.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3183907962

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.693%

Totals Coverage Status
Change from base Build 3182156701: 0.0%
Covered Lines: 5432
Relevant Lines: 7358

💛 - Coveralls

Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good. I guess my main concern would be, what if there's, for example, a long title that was put in the header. It looks like with this it'll always be cut off, yes? With the default layout (just an X button in the header and a close button in the footer), it would work fine, but additional things there might cause trouble.

@bp-cos
Copy link
Contributor Author

bp-cos commented Oct 5, 2022

@brianjgeiger This is true. I was having a hard time with the transition between a normal state and a @media state. When I was adjusting the size of the viewport, it would be resizing normally and then jump to a small view. So I just fixed the header and footer. I see two options: First, allow the header and footer to float until a certain size @media and then go to a fixed height with ellipses. Second: Leave it fixed and then just go with ellipses if it is too long.

@bp-cos bp-cos closed this Feb 3, 2023
@bp-cos bp-cos deleted the feature/eng_4051_b branch February 3, 2023 19:57
@bp-cos bp-cos restored the feature/eng_4051_b branch February 3, 2023 19:57
@bp-cos bp-cos deleted the feature/eng_4051_b branch February 3, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants