Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-4887] [ENG-5293] [ENG-5294] Preprints: Select Page #2167

Conversation

cslzchen
Copy link
Contributor

@cslzchen cslzchen commented Mar 13, 2024

Purpose

Implement the preprints select page

Note: includes code from #2155 for ENG-4887

Summary of Changes

  • New route prerpints/select
  • The select page consists of
    • A temporary non-component header "New Preprints"
    • The PreprintProviderSelection component, which takes the argument 'allProviders' from the route.ts
  • A component PreprintProviderSelection for selecting preprint providers
    • It consists of a heading, a paragraph, the PreprintProviderDisplay component per provider, and a create button
    • Create button is disabled when no provider is selected.
    • When create button is clicked with a provider selected, it transits to the preprint.submit page with the provider's ID
  • A component PreprintProviderDisplay for displaying one preprint provider
    • When it's selected, it updates its parent component with the current selected provider
    • In addition, it un-select previously selected sibling component

Note

  • Inline style of the provider's description seems to break the expected ... overflow.
  • Ended up using {{!-- template-lint-disable no-invalid-interactive --}} to allow clickable div in order for flex to work

Screenshot(s)

Screenshot 2024-03-18 at 8 29 34 PM

Screenshot 2024-03-18 at 8 30 23 PM

Screenshot 2024-03-18 at 12 01 09 PM

Side Effects

N/A

QA Notes

N/A

@cslzchen cslzchen marked this pull request as ready for review March 18, 2024 16:04
@cslzchen cslzchen changed the title [ENG-5293] [ENG-5294] Select Page Enhanced [ENG-4887] [ENG-5293] [ENG-5294] Preprints: Select Page Mar 19, 2024
@bp-cos bp-cos requested a review from futa-ikeda March 19, 2024 18:02
Copy link
Contributor

@futa-ikeda futa-ikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good! I just had a couple suggestions

Copy link
Contributor

@futa-ikeda futa-ikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And how we want to handle clicking on the provider card will addressed once we have mockups for that

@cslzchen cslzchen merged commit 0bdf91f into CenterForOpenScience:feature/preprints-phase-2 Mar 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants