-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-4887] [ENG-5293] [ENG-5294] Preprints: Select Page #2167
[ENG-4887] [ENG-5293] [ENG-5294] Preprints: Select Page #2167
Conversation
50f47d4
to
7c422ca
Compare
app/preprints/-components/preprint-provider-selection/component.ts
Outdated
Show resolved
Hide resolved
app/preprints/-components/preprint-provider-selection/component.ts
Outdated
Show resolved
Hide resolved
app/preprints/-components/preprint-provider-selection/template.hbs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good! I just had a couple suggestions
app/preprints/-components/preprint-provider-selection/template.hbs
Outdated
Show resolved
Hide resolved
app/preprints/-components/preprint-provider-selection/component.ts
Outdated
Show resolved
Hide resolved
app/preprints/-components/preprint-provider-selection/component.ts
Outdated
Show resolved
Hide resolved
6b9d277
to
8e3dd9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! And how we want to handle clicking on the provider card will addressed once we have mockups for that
0bdf91f
into
CenterForOpenScience:feature/preprints-phase-2
Purpose
Implement the preprints select page
Note: includes code from #2155 for ENG-4887
Summary of Changes
prerpints/select
select
page consists ofPreprintProviderSelection
component, which takes the argument 'allProviders' from theroute.ts
PreprintProviderSelection
for selecting preprint providersPreprintProviderDisplay
component per provider, and a create buttonpreprint.submit
page with the provider's IDPreprintProviderDisplay
for displaying one preprint providerNote
...
overflow.{{!-- template-lint-disable no-invalid-interactive --}}
to allow clickablediv
in order forflex
to workScreenshot(s)
Side Effects
N/A
QA Notes
N/A