[ENG-4892] Added the metadata to the review page #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futa-ikeda
requested changes
Apr 19, 2024
futa-ikeda
requested changes
Apr 29, 2024
futa-ikeda
approved these changes
Apr 30, 2024
| } | ||
|
|
||
| public get displayPublicationDoi(): string { | ||
| return this.preprint.articleDoiUrl || this.intl.t('general.not-applicable'); |
There was a problem hiding this comment.
Ahh, I like using this property for the original publication doi 👍
bp-cos
merged commit ef09064
into
CenterForOpenScience:feature/preprints-phase-2
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Continue to flesh out the review page
Summary of Changes
Added the information for the metadata page. It's a bit rough right now and it will get smooter.
Screenshot(s)
Side Effects
none
QA Notes
None