New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-3769: Fix a11y issue on draft registration pages #2199

Merged

brianjgeiger merged 1 commit into CenterForOpenScience:develop from uditijmehta:fix/wcag-a11y-draft-registration

Apr 29, 2024

Contributor

uditijmehta commented Apr 29, 2024 •

edited by jira bot

Loading

Ticket: ENG-3769
Feature flag: n/a

Purpose

Fix a11y of an SVG icon on draft registration pages

Summary of Changes

Changed @ariaHidden to ensures the SVG icon is not hidden.
Added aria-label.

Screenshot(s)

Side Effects

QA Notes


          ENG-3769: Fix a11y issue on draft registration pages

d89beb2

uditijmehta requested review from brianjgeiger and futa-ikeda

April 29, 2024 16:35

coveralls commented Apr 29, 2024

Pull Request Test Coverage Report for Build 8882162629

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 68.1%

Totals
Change from base Build 8727479843:	0.007%
Covered Lines:	6138
Relevant Lines:	8763

💛 - Coveralls

futa-ikeda approved these changes

View reviewed changes

brianjgeiger approved these changes

View reviewed changes

Contributor

brianjgeiger left a comment

Looks good and fixes the problem.

brianjgeiger merged commit 7665e3c into CenterForOpenScience:develop

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment