Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-5641] and [ENG-5303] Add the file upload component #2223

Merged

Conversation

bp-cos
Copy link
Contributor

@bp-cos bp-cos commented May 23, 2024

Purpose

Add a file component widget to upload and display a file

Summary of Changes

Added a new page with the new widget and logic to display it.

Screenshot(s)

Screenshot 2024-05-23 at 1 26 09 PM

Screenshot 2024-05-23 at 1 26 30 PM

Screenshot 2024-05-23 at 1 26 54 PM

Side Effects

Works in mirage ... might not work on staging3

QA Notes

Test away

@bp-cos bp-cos requested a review from brianjgeiger May 23, 2024 19:27
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few non-deleted comments, a little typing, a couple of other questions. Overall, looks good. Fingers crossed it works on staging.

Also, there are a few test failures. One looks very easy to fix, but I'm not sure about the other two.

app/preprints/-components/submit/file/component.ts Outdated Show resolved Hide resolved
app/preprints/-components/submit/file/component.ts Outdated Show resolved Hide resolved
mirage/config.ts Outdated Show resolved Hide resolved
mirage/views/file.ts Outdated Show resolved Hide resolved
mirage/views/file.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good when tests pass.

@bp-cos bp-cos merged commit 1a3c3db into CenterForOpenScience:feature/preprints-phase-2 May 24, 2024
9 checks passed
@bp-cos bp-cos deleted the feature/eng-5641 branch May 24, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants