-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-5641] and [ENG-5303] Add the file upload component #2223
[ENG-5641] and [ENG-5303] Add the file upload component #2223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few non-deleted comments, a little typing, a couple of other questions. Overall, looks good. Fingers crossed it works on staging.
Also, there are a few test failures. One looks very easy to fix, but I'm not sure about the other two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good when tests pass.
1a3c3db
into
CenterForOpenScience:feature/preprints-phase-2
Purpose
Add a file component widget to upload and display a file
Summary of Changes
Added a new page with the new widget and logic to display it.
Screenshot(s)
Side Effects
Works in mirage ... might not work on staging3
QA Notes
Test away