-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-5834] Add a withdrawal feature #2250
Merged
bp-cos
merged 10 commits into
CenterForOpenScience:feature/preprints-phase-2
from
bp-cos:feature/withdrawal
Jun 25, 2024
Merged
[ENG-5834] Add a withdrawal feature #2250
bp-cos
merged 10 commits into
CenterForOpenScience:feature/preprints-phase-2
from
bp-cos:feature/withdrawal
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…character length.
brianjgeiger
requested changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one or two small things. Otherwise, it looks about right as near as I can tell.
...rints/-components/submit/preprint-state-machine/action-flow/withdrawal-preprint/template.hbs
Show resolved
Hide resolved
brianjgeiger
approved these changes
Jun 25, 2024
futa-ikeda
approved these changes
Jun 25, 2024
bp-cos
merged commit Jun 25, 2024
5342ab8
into
CenterForOpenScience:feature/preprints-phase-2
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add the logic to be able to withdrawal a preprint in the edit flow.
Summary of Changes
Added logic to the route to prevent entry to the edit flow from a url
Fixed a bug on regarding subject
Added a dialog box to facilitate the withdrawal process
Screenshot(s)
Side Effects
Likely a bunch
QA Notes
Let's see if it works.