Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EOSF-711] Update file-browser on file-detail page to take more properties #34

Conversation

baylee-d
Copy link

Purpose

To add more properties to the file-browser on the file-detail page. Properties added via CenterForOpenScience/ember-osf#300 (review)

Summary of Changes

Set multiple to false, unselect to false, and openOnSelect to true.

Ticket

https://openscience.atlassian.net/browse/EOSF-711

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md (don't have initial release yet)

jamescdavis
jamescdavis previously approved these changes Nov 13, 2017
Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. 🔥 🔥 🔥

@baylee-d baylee-d force-pushed the feature/add-properties-to-file-detail-file-browser branch from 2c2b4af to 2d900c6 Compare November 13, 2017 15:14
Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 5.645% when pulling 2d900c6 on baylee-d:feature/add-properties-to-file-detail-file-browser into bc53379 on CenterForOpenScience:develop.

@jamescdavis jamescdavis merged commit b5b64ab into CenterForOpenScience:develop Nov 13, 2017
@baylee-d baylee-d deleted the feature/add-properties-to-file-detail-file-browser branch January 17, 2018 16:05
@jamescdavis jamescdavis added this to the 0.1.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants