Changed from default queryParamsDidChange to custom one, stopping cer… #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tain page refeshes from going through and causing promises to be rejected. Certain actions would trigger the function multiple times. Adding the Ember.run.once() function around it stops this from happening. Setting refreshModel to true under queryParams is what is calling this function. See the querryParamsDidChange function in https://github.com/emberjs/ember.js/blob/lts-2-8/packages/ember-routing/lib/system/route.js . See emberjs/ember.js#5566 for more info on the issue, and more possible fixes. This fix could possibly change some interactions on this route in the future (more queryParams added). If old function is desired, just comment out the new one, and ember will use its default. For future reference there may be other possible fixes with observers that do not override the default queryParamsDidChange function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://openscience.atlassian.net/browse/SVCS-393
Purpose
Fix TransactionAborted rejected promise error and Unhandled Promise error detected.
Summary of changes
setting a queryParams refreshModel variable to true causes Ember's defualt queryParamsDidChange function to fire multiple times, causing these errors.
Added a custom queryParamsDidChange which will only fire the refresh command once.
See commit message for more info.
Links from commit message:
issue: emberjs/ember.js#5566 (old version of ember)
file where queryParamsDidChange is defined: https://github.com/emberjs/ember.js/blob/lts-2-8/packages/ember-routing/lib/system/route.js
Testing notes