fix tests to not expose email

CenterForOpenScience · Jul 30, 2018 · 81c1500 · 81c1500
1 parent 7372fd6
commit 81c1500
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/api_tests/nodes/views/test_node_contributors_list.py b/api_tests/nodes/views/test_node_contributors_list.py
@@ -596,7 +596,8 @@ def test_contributor_create_invalid_data(
         assert res.status_code == 400
         assert res.json['errors'][0]['detail'] == exceptions.ParseError.default_detail
 
-    def test_add_contributor_dont_expose_email( self, app, user, user_two, project_public, data_user_two, url_public):
+    def test_add_contributor_dont_expose_email(
+            self, app, user, user_two, project_public, data_user_two, url_public):
 
         res = app.post_json_api(
             url_public,
@@ -961,7 +962,7 @@ def test_add_unregistered_contributor_with_fullname(
             project_public.reload()
             assert res.status_code == 201
             assert res.json['data']['attributes']['unregistered_contributor'] == 'John Doe'
-            assert res.json['data']['attributes']['email'] is None
+            assert res.json['data']['attributes'].get('email') is None
             assert res.json['data']['embeds']['users']['data']['id'] in project_public.contributors.values_list(
                 'guids___id', flat=True)
 
@@ -981,7 +982,7 @@ def test_add_contributor_with_fullname_and_email_unregistered_user(
             project_public.reload()
             assert res.status_code == 201
             assert res.json['data']['attributes']['unregistered_contributor'] == 'John Doe'
-            assert res.json['data']['attributes']['email'] == 'john@doe.com'
+            assert res.json['data']['attributes'].get('email') is None
             assert res.json['data']['attributes']['bibliographic'] is True
             assert res.json['data']['attributes']['permission'] == permissions.WRITE
             assert res.json['data']['embeds']['users']['data']['id'] in project_public.contributors.values_list(
@@ -1005,7 +1006,7 @@ def test_add_contributor_with_fullname_and_email_unregistered_user_set_attribute
             project_public.reload()
             assert res.status_code == 201
             assert res.json['data']['attributes']['unregistered_contributor'] == 'John Doe'
-            assert res.json['data']['attributes']['email'] == 'john@doe.com'
+            assert res.json['data']['attributes'].get('email') is None
             assert res.json['data']['attributes']['bibliographic'] is False
             assert res.json['data']['attributes']['permission'] == permissions.READ
             assert res.json['data']['embeds']['users']['data']['id'] in project_public.contributors.values_list(
@@ -1028,7 +1029,7 @@ def test_add_contributor_with_fullname_and_email_registered_user(
             project_public.reload()
             assert res.status_code == 201
             assert res.json['data']['attributes']['unregistered_contributor'] is None
-            assert res.json['data']['attributes']['email'] == user_contrib.username
+            assert res.json['data']['attributes'].get('email') is None
             assert res.json['data']['embeds']['users']['data']['id'] in project_public.contributors.values_list(
                 'guids___id', flat=True)