[OSF-7362] Use yarn instead of npm to install modules #6746
Conversation
brianjgeiger
changed the title
| @@ -166,7 +166,7 @@ services: | |||
|
|
|||
| preprints: | |||
| image: quay.io/centerforopenscience/ember-preprints:develop | |||
| command: /bin/bash -c "npm install && ./node_modules/bower/bin/bower install --allow-root --config.intedractive=false && ./node_modules/ember-cli/bin/ember serve --host 0.0.0.0 --port 4200" | |||
| command: /bin/bash -c "yarn --pure-lockfile --no-progress --no-emoji && ./node_modules/bower/bin/bower install --allow-root --config.interactive=false && ./node_modules/ember-cli/bin/ember serve --host 0.0.0.0 --port 4200" | |||
There was a problem hiding this comment.
Our other Dockerfiles needed to install Yarn. Can you clarify why the OSF does not need this change?
Also: other PRs activating Yarn do not use some of these flags. If we find they are valuable, we might want to use the same consistent commands / set of flags across all of our repos.
There was a problem hiding this comment.
This is a change to the docker-compose file, so It's using the preprints image, but running a different command. This is so that, when developing, the local changes will be synced in the container, and ember serve will be running (which will trigger ember builds as files are changed).
The reason for the extra flags --no-progress and --no-emoji is that console output console output is superfluous here. You want the output during a regular image build (docker built --tag whatever .). Yarn is smart enough to know when it's in a CI environment, so it's not necessary to add these flags in the travis config.
There was a problem hiding this comment.
Interesting! And yes, I didn't look at the line above closely enough.
So we're not quite at the point of using Yarn for the OSF yet- just making sure that preprints obeys the settings we used elsewhere.
It's interesting that we need this command in addition to the Dockerfile in preprints. Still getting a handle on the interdependencies in different repos. Thanks.
|
Yarn has two benefits: fast installation and version locking. I don't see a yarn.lock file in this repo, however, either before or after this change. Is there a specific reason why one isn't added? |
|
Confirmed that the container builds and runs with this change. Two questions for developer before moving ahead, but hopefully these will both be straightforward. |
|
My objective with this PR was not to add yarn to the main OSF repo, but to make sure that we run yarn commands consistently within the preprints container. |
|
@icereval @brianjgeiger Need this merged since ember-preprints develop is using yarn |
|
@binoculars Is it needed needed? I know we want to move OSF over, but my impression was that the ember apps and OSF not directly linked, and staging right now is running with preprints moved to Yarn but not the OSF. I'm not opposed to doing it in general, but I'd probably have @sloria take a quick look before moving the OSF over. |
|
This is just so that the build uses yarn when you start the container up in development. The command is overridden for production. |
❗️ Depends on CenterForOpenScience/ember-osf-preprints#249
Purpose
Replaces npm with yarn (better node.js dependency management)
Changes
Updates a single line in the docker-compose file
Side effects
N/A
Ticket
https://openscience.atlassian.net/browse/OSF-7362