Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Beat Script Bugs #6747

Merged

Conversation

mfraezz
Copy link
Member

@mfraezz mfraezz commented Jan 19, 2017

Purpose

Extension to #6737

Changes

  • Add missed field to ExternalAccount
  • Ensure SELECT'd user_id's belong to OSFUser objects

Side effects

None Expected

Ticket

#OSF-7335

Copy link
Contributor

@sloria sloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look correct; thanks.

@mfraezz mfraezz force-pushed the feature/beat-django-compat branch 2 times, most recently from 1441d93 to a4ab6ad Compare January 19, 2017 18:04
@sloria
Copy link
Contributor

sloria commented Jan 19, 2017

Test failures are unrelated to this PR, and have since been fixed on develop.

@sloria sloria merged commit 66b5a61 into CenterForOpenScience:develop Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants