Add API field for blog to the preprint provider model [OSF-7405] #6821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfraezz
reviewed
Feb 6, 2017
osf/models/preprint_provider.py
Outdated
| @@ -30,6 +30,7 @@ class PreprintProvider(ObjectIDMixin, BaseModel): | |||
| social_twitter = models.CharField(null=True, blank=True, max_length=200) # max length on prod: 8 | |||
| social_facebook = models.CharField(null=True, blank=True, max_length=200) # max length on prod: 8 | |||
| social_instagram = models.CharField(null=True, blank=True, max_length=200) # max length on prod: 8 | |||
| blog = models.URLField(null=True, blank=True) | |||
There was a problem hiding this comment.
Consider renaming to blog_url, to better follow naming conventions for URLFields. Also, should this have a max_length?
There was a problem hiding this comment.
URLField has a default max_length of 200, figured I'd not change it.
erinspace
force-pushed
the
feature/blog_api_field_preprint_provider
branch
from
71dcdbe
to
8272fb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add field to preprint provider model to store a link to a blog, and include in the API preprint provider serializer.
Changes
Side effects
Migration will need to be run for the changes to work properly
Ticket
https://openscience.atlassian.net/browse/OSF-7405