Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-239] Update to node.js version 8 #7507

Merged
merged 2 commits into from
Aug 2, 2017
Merged

[DEV-239] Update to node.js version 8 #7507

merged 2 commits into from
Aug 2, 2017

Conversation

binoculars
Copy link
Member

Purpose

Updates Node.js to a maintained version

Changes

  • Add .npmrc to ignore optional dependencies - would use yarn, but ignore-optional flag works not like expected yarnpkg/yarn#2666 is needed before we can use it. livedb's optional dependency, hiredis will not build on newer node.js versions.
  • Update Dockerfile to use node.js version 8
    • npm cache clean requires --force flag

Side effects

  • May affect the wiki / ShareJS, so we'll need to regression test that
  • Assets should be unaffected, but again, something to watch out for

Ticket

https://openscience.atlassian.net/browse/DEV-239

@sloria sloria requested a review from icereval July 25, 2017 13:45
Dockerfile Outdated
&& rm "node-v$NODE_VERSION-linux-x64.tar.gz" SHASUMS256.txt.asc \
&& npm install -g npm@"$NPM_VERSION" \
&& npm cache clear \
RUN curl -sL https://deb.nodesource.com/setup_8.x | bash - \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shell'ing scripts directly from the internet is a bit scary. If this script is really worth using rather than the docker hub image, please add a sha256 check directly to the Dockerfile, there should be examples in the docker-library repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to use that--we can optimize later with multi-stage builds later on once jenkins with modern docker is ready.

Copy link
Contributor

@icereval icereval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sloria - this will need to be deployed to stage to verify it doesn't break any major functionality so let it bake in a bit, but changes look good (don't expect a break, if anything it more of a miracle our out of date version continued to work 👍 this long)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants