Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Replace wbv0 ...url_for with wbv1 [OSF-8696] #7788

Merged
merged 5 commits into from
Dec 5, 2017
Merged

[Feature] Replace wbv0 ...url_for with wbv1 [OSF-8696] #7788

merged 5 commits into from
Dec 5, 2017

Conversation

alexschiller
Copy link
Contributor

Purpose

WBV0 is kill.

Changes

Replace calls to waterbutler_url_for with calls to waterbutler_api_url_for

Side effects

Removed skip logic from test that said "Unskip when figshare addon is implemented" from... 10 months ago.

Ticket

https://openscience.atlassian.net/browse/OSF-8696

QA notes

  1. Make sure you can still upload conference files via email. I only could half test this since I'm not sure how to receive emails locally.
  2. Make sure that files and folders (and addons) are still archived to osfstorage properly when registered

@alexschiller alexschiller changed the title [Feature] Replace wbv0 url_for with wbv1 [OSF-8696] [Feature] Replace wbv0 ...url_for with wbv1 [OSF-8696] Oct 9, 2017
@brianjgeiger
Copy link
Collaborator

@alexschiller Conflicts

@brianjgeiger brianjgeiger merged commit 390a8f3 into CenterForOpenScience:develop Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexschiller @brianjgeiger