[PLAT-767] Fix ordering for user nodes AND quickfiles #8390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the file node date modified.
Johnetordoff
changed the title
… into hotfix-fix-order-dasboard * 'master' of https://github.com/CenterForOpenScience/osf.io: (623 commits) Anonymize IP address for Keen. Move back imports to prevent app startup from hanging Allow removing stuck registrations with addons fix mocking for gitlab Bump version and update changelog fix tests for non-dict based client attributes Update gitlab serializers for fangorn config js Add enforce_csrf waffle switch so that this can be merged earlier Update markdown-it-video with infinite loop fix Fix indentation Improve tests by using user cookie method and faster user creation Tests to ensure API requests with Session auth fail without CSRF protection Travis and Test Speed ups Rename --quick to --all Don't transact to avoid deadlocks Add script to fix poor mapping logic -h/t @caseyrollins Add same enforce_csrf method as drf's SessionAuthentication replace bad reverse migration with warning Use timezone.now() when checking for failed registrations Remove duplicate psyarxiv custom subject. ... Signed-off-by: John Tordoff <john@cos.io> # Conflicts: # api_tests/users/views/test_user_files_list.py
Pull Request Test Coverage Report for Build 30739
💛 - Coveralls |
sloria
pushed a commit
that referenced
this pull request
Sep 18, 2018
This separates the nodes fix from #8390 **Purpose** Fix sorting nodes in the dashboard by modified date **Changes** Sort nodes by last_logged instead of modified **Ticket** https://openscience.atlassian.net/browse/PLAT-767
|
I separated the node ordering fix into its own commit: 9f70599 . That's headed to prod. The Quick Files fix will need further consideration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The order of nodes modified on the OSF dashboard is out of order when based on date modified. And it also fixes the user quickfiles view from being out of order.
Changes
Dashboard:
Quickfiles:
date_modifiedappears.QA Notes
Dashboard:
I tested this by using the shell to change the date modified to be different then date last_logged to create the discrepancy that occurs normally. I've not sure how this could be forced to happen on staging, but recorded instances where it's known to happen should be fixed.
Quickfiles:
This bug happens because the “date modified” is the date that quickfiles are sorted by, but it’s not the date that appears to the user.
Documentation
Bug fix needs no docs.
Side Effects
None that I know of.
Ticket
https://openscience.atlassian.net/projects/PLAT/issues/PLAT-767