[SVCS-826] S3 Compatibility #8418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NyanHelsing
changed the title
NyanHelsing
changed the title
NyanHelsing
force-pushed
the
ft/s3-compat
branch
from
fe328e7
to
b4be384
Compare
NyanHelsing
changed the title
- adds host name to Node Settings model in s3 - updates waterbutler url creators to add hostname as a query param
Original implementation tried to put the host on node_settings, the final version puts the attribute on the external account model.
The serializer wasn't passing a couple of attributes, hots and nickname, and the view model did not have attributes to accommodate them. This adds in the attributes to allow this data to pass to and from the backend.
Defer till future so product can consider it longer. This removes the modify dialog that wouild allo a user to change settings on an externalAccount without requiring them to reenter any information they had already entered. Note that users will be required to use the "Connect or Reauthorize" dialog, and they will be required to enter all information for the account.
Removes the facility for a user to provide a string to use as a nickname for the account. The system will instead try to guess the most useful thing, using the account's username, and then falling back to the url of the provider.
Runs migrations to remove nickname field from ExternalAccount model. This is being deferred for product to have more time to discuss its merits.
NyanHelsing
force-pushed
the
ft/s3-compat
branch
from
eded585
to
17ffec5
Compare
Removes extraneous `console.log` statements, etc..
Rather than create new fields to store settings about the ExternalAccount, format the settings into a string and store that in provider_id so we don't add new fields. Update serializer/views so they can figure out how to get the data in and out of the string.
Missing a paren and a few semicolons in addonSettings.js
user_settings mako file was missing a closing table row, this adds it back in.
A couple of errors happend when creating the external account, like the connection to s3 looking for attributes in the wrong places. This resolves those problems
`provider_id` encodes some values needed on a provider-type basis. This migration takes all the existing values and updates them to the new format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR enables users to connect any s3 compatible storage provider to their OSF account using the s3 addon.
Changes
QA Notes
Ensure that users can connect s3-compatible providers
Documentation
Side Effects
Users modifying an account will necessarily modify that account for any other user that also has connected this account. (This is already a behaviour experienced using the 'connect or reauthorize dialog)
Ticket
https://openscience.atlassian.net/browse/SVCS-826