Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/APIv2 Node Settings [PLAT-924] #8536

Merged
merged 20 commits into from
Jul 27, 2018
Merged

Feature/APIv2 Node Settings [PLAT-924] #8536

merged 20 commits into from
Jul 27, 2018

Commits on Jul 10, 2018

  1. Begin adding Node Settings to APIv2. 

    - Url added, view and serializer started.
- New permission class IsContributor added.
    @pattisdr
    pattisdr committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    d741ec8 View commit details
    Browse the repository at this point in the history

  2. Make sure user is viewing or has WRITE permissions in IsContributor

    @erinspace
    erinspace committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    e4bde4d View commit details
    Browse the repository at this point in the history

  3. Add NodeSettingsUpdateSerializer for updating fields on NodeSettings 

    - Use this serializer for PUT or PATCH requests
- Update the view to choose the right serializer
    @erinspace
    erinspace committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    60031ad View commit details
    Browse the repository at this point in the history

  4. Add node settings test file.

    @pattisdr
    pattisdr committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    010492a View commit details
    Browse the repository at this point in the history

  5. Add missed items to IsContributor permission class and NodeSettings s… 

    …erializer to get tests to run.
    @pattisdr
    pattisdr committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    0d03e56 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. Add tests for the NodeSettingsSerializer and GET requests

    @erinspace
    erinspace committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    d5a861d View commit details
    Browse the repository at this point in the history

  2. Add test for view_only_links relationship

    @erinspace
    erinspace committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    98b94b5 View commit details
    Browse the repository at this point in the history

  3. Add APIv2 update tests for NodeSettings.

    @pattisdr
    pattisdr committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    b6cd5f0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/node_settings_apiV2' of https://github.com/patt… 

    …isdr/osf.io into feature/node_settings_apiV2

* 'feature/node_settings_apiV2' of https://github.com/pattisdr/osf.io:
  Add test for view_only_links relationship
  Add tests for the NodeSettingsSerializer and GET requests

# Conflicts:
#	api_tests/nodes/views/test_node_settings.py
    @pattisdr
    pattisdr committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    a62f24c View commit details
    Browse the repository at this point in the history

  5. Add version 2.9 to API and add to serializer context so addons aren't… 

    … loaded multiple times.

- Version 2.9 deprecates access_requests_enabled field from NodeSerializer and moves it to NodeSettings serializer.
- Wiki and forward addons pushed to serializer context so they are not loaded multiple times in serializer method fields and in update method.
    @pattisdr
    pattisdr committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    9c2026e View commit details
    Browse the repository at this point in the history

  6. Expose settings relationship on Node serializer only.

    @pattisdr
    pattisdr committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    2e43308 View commit details
    Browse the repository at this point in the history

  7. Modify is_deprecated so only a min_version or max_version can be spec… 

    …ified, if desired.

- Modify HideIfWikiDisabled so versions greater than 2.7 don't show wiki relationship on nodes if wiki is disabled. Formerly, this feature was just restricted to 2.8.
- List settings field as field that doesn't appear on registration serializer.
- Add test for deprecated access_requests_enabled field on NodeSerializer
    @pattisdr
    pattisdr committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    ab33946 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2018

  1. Add PUT permissions tests for APIv2 NodeSettings.

    @pattisdr
    pattisdr committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    c21ac61 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2018

  1. Move method for setting access requests to node model 

    [#PLAT-824]

- Keep old v1 route
- Add model tests
    @erinspace
    erinspace committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    fb7db32 View commit details
    Browse the repository at this point in the history

  2. Use new access_requests_enabled method on node, add tests for logging

    @erinspace
    erinspace committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    a3468e5 View commit details
    Browse the repository at this point in the history

  3. Check for logging on other node and wiki actions that have associated… 

    … logs

Update tests to check for node logs
    @erinspace
    erinspace committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    a6733d0 View commit details
    Browse the repository at this point in the history

  4. Make update methods consistent in passing auth

    @erinspace
    erinspace committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    d74bf6a View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2018

  1. Override to_representation on NodeSettingsUpdateSerializer to use a d… 

    …ifferent serializer for the response versus the request.
    @pattisdr
    pattisdr committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    bee8d6a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io 

     into feature/node_settings_apiV2

- Catch NodeStateErrors when running set_editing and fix but in to_representation.
    @pattisdr
    pattisdr committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    ab17e69 View commit details
    Browse the repository at this point in the history

  3. Fix NodeSettings tests.

    @pattisdr
    pattisdr committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    dd681e7 View commit details
    Browse the repository at this point in the history