Set is_root=True for old folders set as root_node for existing NodeSettings [PLAT-578] #8537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttings [#PLAT-578]
erinspace
force-pushed
the
feature/update_old_root_nodes
branch
from
5c9f56e
to
191e041
Compare
|
Tested locally on local prod backup. Took ~3m24s: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The new
get_rootmethod in theOsfStorageFolderManagerrelies onis_root=Truebeing set for all root folders. This is the case for new nodes as that setting happens in theon_addmethod of osfstorage'sNodeSettingsmodel.Changes
is_root=Truefor allOsfStorageFolderobjects that have a fk relationship to a NodeSettings model, as those are all root folders.QA Notes
We'll do QA on this one!
Documentation
None necessary
Side Effects
None anticipated
Ticket
https://openscience.atlassian.net/browse/PLAT-578