Feature/Manage Two-Factor Auth in V2 [PLAT-963] #8565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattisdr
commented
Jul 19, 2018
| two_factor_enabled = ser.BooleanField(write_only=True, required=False) | ||
| two_factor_verification = ser.IntegerField(write_only=True, required=False) | ||
|
|
||
| def to_representation(self, instance): |
There was a problem hiding this comment.
Similarly implemented in #8536.
Allows request/response to use different serializers. This is different than different serializers for different types of request methods.
| user_addon = None | ||
| if 'two_factor_enabled' == attr: | ||
| if value: | ||
| if not instance.has_addon('twofactor'): |
There was a problem hiding this comment.
If two factor already enabled and attempting to enable, ignores. Likewise for disabling.
pattisdr
force-pushed
the
feature/apiv2_two_factor
branch
from
92ad966
to
fd84cd2
Compare
This was referenced Jul 20, 2018
|
@Johnetordoff is going to be adding commits to my PR from here. #8559. |
|
These commits have been pulled into @Johnetordoff 's PR #8559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Needed for Embosf User Account Settings Page
Changes
Added a
/v2/users/<uid>/settings/endpoint, GET/PATCH onlytwo_factor_enabled, writeable boolean, turns two factor on/offtwo_factor_verification(write-only int field), enter 2f codeQA Notes
Documentation
Located here: CenterForOpenScience/developer.osf.io#24
Side Effects
Ticket
https://openscience.atlassian.net/browse/PLAT-963