Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-913] Fixes for gitlab #8578

Merged

Conversation

Johnetordoff
Copy link
Contributor

@Johnetordoff Johnetordoff commented Jul 24, 2018

Purpose

http:// schemes are add to Gitlab hosts too much this removes them. Like so:
screen shot 2018-07-24 at 12 03 02 pm

Changes

  • removes the excessive schemes strings.
  • changes default http://gitlib.com
  • better a catch the TOS error.
  • Add suggestion to reconnect to error message.

QA Notes

Connect to a Gitlab instance and see that the link takes you to the right page.

Documentation

None needed.

Side Effects

None that I know of.

Ticket

https://openscience.atlassian.net/projects/PLAT/issues/PLAT-913

Signed-off-by: John Tordoff <john@cos.io>
@Johnetordoff Johnetordoff changed the base branch from develop to master July 25, 2018 15:00
@Johnetordoff Johnetordoff changed the title [PLAT-913] Fix doubly added schemes for gitlab [PLAT-913][WIP] Fix doubly added schemes for gitlab Jul 25, 2018
Signed-off-by: John Tordoff <john@cos.io>
@Johnetordoff Johnetordoff changed the title [PLAT-913][WIP] Fix doubly added schemes for gitlab [PLAT-913][WIP] Fixes for gitlab Jul 25, 2018
@Johnetordoff Johnetordoff changed the title [PLAT-913][WIP] Fixes for gitlab [PLAT-913] Fixes for gitlab Jul 25, 2018
@coveralls
Copy link

coveralls commented Jul 25, 2018

Pull Request Test Coverage Report for Build 30726

  • 3 of 7 (42.86%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+21.9%) to 83.932%

Changes Missing Coverage Covered Lines Changed/Added Lines %
addons/gitlab/api.py 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
api/nodes/views.py 1 96.86%
addons/gitlab/api.py 1 49.09%
admin/nodes/views.py 2 82.91%
Totals Coverage Status
Change from base Build 30689: 21.9%
Covered Lines: 31786
Relevant Lines: 37871

💛 - Coveralls

@sloria sloria merged commit 9eb5e13 into CenterForOpenScience:master Aug 3, 2018
@sloria sloria deleted the hotfix-gitlab-client branch August 3, 2018 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants