Render Dataverse Files, Deleted File metadata [PLAT-578] #8584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update node > target - put in future note to change other node-specific formatters for deleted file metadata
erinspace
commented
Jul 26, 2018
| 'allow_comments': file_node.provider in settings.ADDONS_COMMENTABLE, | ||
| }) | ||
| error_msg = ERROR_MESSAGES[error_type].format(**format_params) | ||
| if isinstance(target, AbstractNode): |
There was a problem hiding this comment.
I debated awhile on this one -- just check if the target is node early, or try to tweak the return value based on the type of target. In the end I went with this, with a TODO for the future, because I figured that the file views will most likely be emberized soon.
If however we want this to be a bit more robust at this point I'd also understand!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Just a few little things to address the most recent round of QA.
Changes
dataverse:
deleted file metadata:
QA Notes
Viewing dataverse files and deleted file metadata should work now!
Documentation
Side Effects
None anticipated
Ticket
https://openscience.atlassian.net/browse/PLAT-578