[ENG-965] Feature/education employment endpoints #9163
Conversation
This reverts commit 994b9b5.
* Decouples profile and object types for user profile testing * Requires ongoing to be defined if start_date is provided in a request
…on_employment_endpoints
UdayVarkhedkar
changed the title
| # start date with undefined ongoing fails | ||
| undefined_ongoing = payload(institution='hullo', start_date='2018-01-01') | ||
| res = app.post_json(list_url, undefined_ongoing, auth=user.auth, expect_errors=True) | ||
| assert res.status_code == 400 |
There was a problem hiding this comment.
Nice addition to this test.
|
Looks good! As we discussed in my PR, I like your implementation of validate_dates better! |
…knowledge string representation of booleans in QueryDict of parameters
… 'ongoing' parameter
|
Looks good! |
api/base/schemas/utils.py
Outdated
| if history.get('start_date') and history.get('end_date'): | ||
| if (end_date - start_date).days <= 0: | ||
| raise InvalidModelValueError(detail='End date must be greater than or equal to the start date.') | ||
| if not history.get('ongoing', False): |
There was a problem hiding this comment.
Since we're here, could you make this a positive if rather than the negative case, so it's a bit more readable? So if history.get('ongoing', False): and do the other branch, then put this branch in the else?
There was a problem hiding this comment.
Modified and changes have been tested locally
|
@UdayVarkhedkar Tests are not happy. Are those being handled by one of the related PRs? |
|
Yes, the failing tests are the ones being removed by this PR by Corbin. Tests around the API functionality added/validated by this PR have been run and verified locally. |
Purpose
Verify and update UserEducation and UserEmployment endpoint functionality, request validation, and testing.
Changes
profile_typeandobject_typein endpoint testing and update test functions to fix broken tests (tests were calling invalid functions/attributes)ongoingparameter to be defined ifstart_dateis provided (via jsonschema validation) and add tests accordinglyQA Notes
The UserEducation and UserEmployment API endpoints should be tested/verified by QA. This includes checking the CRUD (create, read, update, and delete) functionality of the API endpoints, verifying that authorization for the API endpoints is in line with expectations, ensuring that parameter validation is working as expected or that helpful errors are provided.
Documentation
No, documentation for these endpoints does not currently exist.
Side Effects
N/A
Ticket
Jira Ticket