[ENG-1747] Upgrade GitHub3.py library to 1.3.0 #9366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addons/github/tests/utils.py
Outdated
|
|
||
|
|
||
| branch_1 = Branch.from_json(dumps({ | ||
| u'commit': { |
There was a problem hiding this comment.
If we could phase out the u-strings for py3 that would be great. We should have a syntax moot some day and decide these details. The deal with u-strings in py3
| @@ -1,5 +1,8 @@ | |||
| import mock | |||
There was a problem hiding this comment.
Wait shouldn't this be addons/github/tests/utils.py, not addons/gitlab/tests/utils.py?
| @@ -52,7 +52,7 @@ def get_path(kwargs, required=True): | |||
| raise HTTPError(http_status.HTTP_400_BAD_REQUEST) | |||
|
|
|||
|
|
|||
| def get_refs(addon, branch=None, sha=None, connection=None): | |||
There was a problem hiding this comment.
Wow all those test changes for this one function...
|
@corbinSanders oops! one more thing can you see if you can remove these lines there's a few more instances of uritemplate bug fixing too. |
|
@corbinSanders What about these lines ? |
👌 |
brianjgeiger
approved these changes
May 4, 2020
|
|
||
| def create_mocked_session(): | ||
| """Use mock to auto-spec a GitHubSession and return an instance.""" | ||
| MockedSession = mock.create_autospec(github3.session.GitHubSession) |
There was a problem hiding this comment.
Well, that seems fancy.
added 2 commits
August 23, 2021 19:16
… into feature/github3py_upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We are currently on 1.0.0a, which was released in 2016. We really should upgrade.
Changes
Modified addons/github/requirements.txt to include most recent version (1.3.0). Added user scope to settings. Modified a bunch of tests to include a mocked session, which is now required for the from_json method.
QA Notes
No
High, please test all GitHub related functionality.
No
Modification
UI
N/A
GitHub addon
Shouldn't
-->
Documentation
N/A
Side Effects
Shouldn't be.
Ticket
https://openscience.atlassian.net/browse/ENG-1747