Adding last updated to summary endpoint [ENG-1879] #9418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaxelb
approved these changes
Jun 16, 2020
aaxelb
requested changes
Jun 16, 2020
aaxelb
approved these changes
Jun 16, 2020
corbinSanders
force-pushed
the
feature/last_updated_summary_metrics
branch
from
f097420
to
2d1ab79
Compare
corbinSanders
force-pushed
the
feature/last_updated_summary_metrics
branch
from
2d1ab79
to
a76eae0
Compare
aaxelb
reviewed
Jun 18, 2020
api/institutions/views.py
Outdated
| @@ -402,7 +402,9 @@ class InstitutionSummaryMetrics(JSONAPIBaseView, generics.RetrieveAPIView, Insti | |||
| # overrides RetrieveAPIView | |||
| def get_object(self): | |||
| institution = self.get_institution() | |||
| return InstitutionProjectCounts.get_latest_institution_project_document(institution) | |||
| results = InstitutionProjectCounts.get_latest_institution_project_document(institution) | |||
| results['last_updated'] = UserInstitutionProjectCounts.get_recent_datetime(institution) | |||
There was a problem hiding this comment.
@corbinSanders thinking on this again, it looks like all metrics should have a timestamp field -- is it possible to get the timestamp off the "latest" InstitutionProjectCounts result that's already being fetched? rather than make additional requests to elastic for UserInstitutionProjectCounts
corbinSanders
force-pushed
the
feature/last_updated_summary_metrics
branch
from
889ec1c
to
7584a40
Compare
aaxelb
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The front end needs the datetime of when institutional metrics were last updated
Changes
Adding field to serializer. Getting the last updated datetime. Updating tests
QA Notes
No
minimal
No
Additive
API
No new version. Use
v2/institutions/<institution_id>/metrics/summary/Institutional dashboard
Shouldn't
-->
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-1879